jwfromm commented on a change in pull request #5082: [Relay, Topi] [TF, MXNet]
Unravel Index operator
URL: https://github.com/apache/incubator-tvm/pull/5082#discussion_r393924803
##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -321,6 +321,12 @@ struct ArgWhereAttrs : public
tvm::AttrsNode<ArgWhereAttrs> {
}
}; // struct ArgWhereAttrs
+/*! \brief Attributes used in unravel_index operators */
+struct UnRavelIndexAttrs : public tvm::AttrsNode<UnRavelIndexAttrs> {
+ TVM_DECLARE_ATTRS(UnRavelIndexAttrs, "relay.attrs.UnRavelIndexAttrs") {
Review comment:
I don't think there's any need to define an attribute type for an operator
without attributes. Although `argwhere` seems to do the same thing you have,
other operators without attributes just don't use one (see `nn.batch_flatten`
as one example). I'd argue we should try to avoid defining unnecessary attrs to
prevent bloat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
