FrozenGene commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-600394618 > Thanks @trevor-m > > @FrozenGene sorry for bothering you but does this ring a bell? > > I feel it is weird that `GetFunction` won't return an invalid/empty value directly when the function name cannot be found. I'm wondering why `LazyJIT` should be called in this scenario? Please see: https://github.com/apache/incubator-tvm/pull/4847/files#diff-8baddb83a9684e8373691bb48a946900R469-R474 When entire program is offloaded, I find previous logic will ```cpp // Execute the whole module using external runtime. ret_.mod = ext_mods[0]; ``` However, current logic we will ```cpp // Import all external runtime modules. for (const auto& it : ext_mods) ret_.mod.Import(it); ``` Could you double check the logic is the same as previous? Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
