masahi commented on issue #4981: [Relay, Topi, TF Frontend] Isfinite operator URL: https://github.com/apache/incubator-tvm/pull/4981#issuecomment-601910117 If it is only TF frontend change, it is totally fine. But you also added a new relay/topi op, and even added new TIR intrinsics, just to support that customer's model. That makes me concerned. TVM is supposed to support other frameworks not just TF, and if we start adding these framework specific corner case ops, it quickly leads to code bloat. I prefer adding new ops only if they could be useful across different frameworks. People use TVM because they want to go fast. Having finteness check doesn't help with that. You should talk to your customer if they can remove it, or if it is fine for us to ignore `Isfinite` op in our frontend. > Also, will it be useful considering training support in TVM? I don't know if it is useful to training. Maybe @MarisaKirisame can comment.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
