kumasento commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-602020720 Hi @FrozenGene Thanks for your explanation. I do have a question about this part, hope you won't mind: 1. Before this PR, we replace `ret_.mod` with `ext_mods[0]` when there is no `lowered_funcs`, which is sensible since no `ret_.mod` is available when `lowered_funcs` does not exist. 2. Now we will always create a `ret_.mod`. What would the logic be if there is only one external module (the condition for `ret_.mod` replacement)? Should we do replacement or import? Also @trevor-m would you mind sending me a minimal workable example? I would like to do the tracing myself as well. Thanks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
