MarisaKirisame commented on a change in pull request #5039: [Relay]
GradientCell Relay Pass
URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396170061
##########
File path: src/relay/transforms/gradient_cell.cc
##########
@@ -44,19 +66,139 @@
namespace tvm {
namespace relay {
+namespace GradientCellPass { // avoid polluting namespace
Review comment:
.cc do not pollute namespace. namespace only get polluted when #include
happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
