kazum commented on a change in pull request #5116: Add thrust support for nms
URL: https://github.com/apache/incubator-tvm/pull/5116#discussion_r396213537
##########
File path: src/runtime/contrib/thrust/thrust.cu
##########
@@ -35,11 +35,12 @@ namespace contrib {
using namespace runtime;
// Performs sorting along axis -1 and returns both sorted values and indices.
-template<typename DataType, typename IndicesType>
+template<typename DataType, typename IndicesType, typename F>
void thrust_sort(DLTensor* input,
DLTensor* out_values,
DLTensor* out_indices,
- bool is_ascend) {
+ bool is_ascend,
+ const F &get_sort_len) {
Review comment:
I think `std::function<int(int)>` looks easier to read than introducing
typename F.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
