zhiics commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r396639383
########## File path: src/relay/analysis/annotated_region_set.h ########## @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/relay/pass/annotated_region_set.h + * \brief Define data structures to extract and manipulate regions from + * a relay function. Regions are denoted by region_begin and region_end + * annotations that exist on all the input and output edges of the region. + */ + +#ifndef TVM_RELAY_ANALYSIS_ANNOTATED_REGION_SET_H_ +#define TVM_RELAY_ANALYSIS_ANNOTATED_REGION_SET_H_ + +#include <tvm/relay/analysis.h> +#include <tvm/relay/attrs/annotation.h> +#include <tvm/relay/expr.h> +#include <tvm/ir/error.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/transform.h> + +#include <string> +#include <unordered_set> +#include <utility> +#include <vector> +#include <list> + +namespace tvm { +namespace relay { + +class AnnotatedRegion; +class AnnotatedRegionSet; + +class AnnotatedRegionNode : public Object { Review comment: I would suggest we change this to a `struct` or just make members public since it only really just carries data. This getters seem to be redundant IMO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
