yzhliu commented on a change in pull request #5121: [TE] reverse-mode autodiff
without any optimization
URL: https://github.com/apache/incubator-tvm/pull/5121#discussion_r396670848
##########
File path: python/tvm/testing.py
##########
@@ -68,6 +69,10 @@ def check_numerical_grads(function, input_values,
grad_values, function_value=No
rtol : float, optional
Relative tolerance.
+
+ acceptable_fail_percentage : float, optional
Review comment:
actually this is the problem of numerical derivative in
`check_numerical_grads` itself. I can change to assert them ("floor", "ceil",
"trunc", "round") to be exact zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
