zhiics commented on a change in pull request #5028: [RELAY] Remove kCompiler
attr from ext mod
URL: https://github.com/apache/incubator-tvm/pull/5028#discussion_r397321424
##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -627,6 +627,7 @@ class CompileEngineImpl : public CompileEngineNode {
const tvm::tir::StringImmNode* symbol_name =
ext_symbol.as<tvm::tir::StringImmNode>();
CHECK(symbol_name) << "No external symbol is set for:\n" <<
AsText(src_func, false);
auto gv = GlobalVar(symbol_name->value);
+ src_func = WithAttr(src_func, attr::kCompiler,
tir::StringImmNode::make("default"));
Review comment:
Also, inorder to use CoW, you may want to use `src_func =
WithAttr(std::move(src_func), ...)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
