tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397929962
########## File path: tests/python/unittest/test_tir_pass_narrow_datatype.py ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import tvm +from tvm import te + + +def lower(sch, args): + binds = {} + arg_list = [] + for x in args: + if isinstance(x, te.tensor.Tensor): + buf = tvm.tir.decl_buffer(x.shape, dtype=x.dtype, name=x.name) + assert x not in binds + binds[x] = buf + arg_list.append(buf) + else: + raise ValueError("args must be Tensor, Buffer or Var") + bounds = te.schedule.InferBound(sch) + stmt = te.schedule.ScheduleOps(sch, bounds) + stmt = tvm.tir.ir_pass.StorageFlatten(stmt, binds, 64, False) + stmt = tvm.tir.ir_pass.NarrowDataType(stmt, 32) Review comment: It would be great if we can add more test cases: - Please also consider use ir_builde to directly build loops - Have testcase that narrows to i16 - Have a loop variable occurs in multiple expressions, one expr overflows, another does not ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
