zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph
Partitioner to support multiple outputs
URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r397973058
##########
File path: src/relay/transforms/partition_graph.cc
##########
@@ -36,36 +36,23 @@
#include <tvm/relay/expr_functor.h>
#include <tvm/relay/transform.h>
-#include <string>
+#include <utility>
#include <unordered_map>
#include <unordered_set>
-#include <utility>
#include <vector>
#include "../backend/utils.h"
+#include "../analysis/annotated_region_set.h"
+
namespace tvm {
namespace relay {
namespace partitioning {
// Cache compiler_begin and compiler_end annotation ops for equivalence check
to
// reduce registry lookup overhead.
-static const Op& compiler_begin_op = Op::Get("annotation.compiler_begin");
-static const Op& compiler_end_op = Op::Get("annotation.compiler_end");
-
-/*!
- * \brief The subgraph properties for partitioning.
- */
-struct Subgraph {
- /*! \brief The subgraph ID. */
- int id;
-
- /*! \brief The input arguments of this subgraph. */
- std::vector<std::pair<Var, Expr>> args;
-
- /*! \brief Nodes in this subgraph. */
- std::unordered_set<Expr, ObjectHash, ObjectEqual> nodes;
-};
+static const Op &compiler_begin_op = Op::Get("annotation.compiler_begin");
Review comment:
keep the original code style: `static const Op&`
Same for all the other places in the rest of PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
