zhiics commented on a change in pull request #5134: [RELAY] Add
MergeCompilerRegions pass
URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397987916
##########
File path: src/relay/transforms/annotate_target.cc
##########
@@ -38,46 +38,144 @@ class AnnotateTargetWrapper : public ExprMutator {
public:
explicit AnnotateTargetWrapper(const std::string& target) : target_(target)
{}
+ Expr Annotate(const Expr& expr) {
+ return InsertEnd(Mutate(expr));
+ }
+
+ bool IsSupported(const Expr& expr) {
+ if (expr->IsInstance<CallNode>()) {
+ Call call = Downcast<Call>(expr);
+ auto fannotate = Op::GetAttr<FTVMAnnotateTarget>("target." + target_);
+ Op op = Downcast<Op>(call->op);
+ CHECK(op.defined());
+ if (fannotate.count(op)) {
+ return fannotate[op](call->attrs, call->args);
+ }
+ }
+ return false;
+ }
+
+ Expr InsertEnd(const Expr& arg) {
+ if (IsSupported(arg)) {
+ const auto *end_op =
+ runtime::Registry::Get("relay.op.annotation._make.compiler_end");
+ CHECK(end_op);
+ Expr end = (*end_op)(arg, target_);
+ return end;
+ }
+ return arg;
+ }
+
Expr VisitExpr_(const CallNode* cn) {
// TODO(@zhiics, @comaniac) Handle composite functions.
auto new_e = ExprMutator::VisitExpr_(cn);
Call call = Downcast<Call>(new_e);
- static auto fannotate = Op::GetAttr<FTVMAnnotateTarget>("target." +
target_);
- Op op = Downcast<Op>(call->op);
- CHECK(op.defined());
-
- if (fannotate.count(op)) {
- bool external = fannotate[op](call->attrs, call->args);
- if (external) {
- tvm::Array<tvm::relay::Expr> compiler_begins;
- for (const auto& it : call->args) {
- const auto* begin_op =
- runtime::Registry::Get("relay.op.annotation._make.compiler_begin");
- CHECK(begin_op);
- Expr begin = (*begin_op)(it, target_);
- compiler_begins.push_back(begin);
- }
- Expr update_call = Call(call->op, compiler_begins, call->attrs);
- const auto* end_op =
- runtime::Registry::Get("relay.op.annotation._make.compiler_end");
- CHECK(end_op);
- Expr end = (*end_op)(update_call, target_);
- return end;
+
+ // add end annotations if the args are supported
+ Array<Expr> compiler_ends;
+ for (const auto& it : call->args) {
+ compiler_ends.push_back(InsertEnd(it));
+ }
+ call = Call(call->op, compiler_ends, call->attrs);
+
+ // add begin annotations if the call node is supported
+ if (IsSupported(call)) {
+ tvm::Array<tvm::relay::Expr> compiler_begins;
+ for (const auto& it : call->args) {
+ const auto* begin_op =
+ runtime::Registry::Get("relay.op.annotation._make.compiler_begin");
+ CHECK(begin_op);
+ Expr begin = (*begin_op)(it, target_);
+ compiler_begins.push_back(begin);
}
- } else {
- LOG(WARNING) << op->name << " in " << target_
- << " is not registered. It will be executed on CPU.";
+ call = Call(call->op, compiler_begins, call->attrs);
}
- return new_e;
+
+ return std::move(call);
+ }
+
+ Expr VisitExpr_(const TupleNode *op) {
Review comment:
use Google C++ code style: `TupleNode* op`, same to the other changes or
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
