jroesch commented on a change in pull request #5154: [NODE][IR] Introduce
StructuralEqual Infra for the unified IR.
URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399450430
##########
File path: tests/python/unittest/test_tir_structural_equal.py
##########
@@ -55,8 +55,8 @@ def test_exprs():
assert tvm.ir.structural_equal(zx * zx, zx * zx)
assert tvm.ir.structural_equal(zx * zx, zy * zy, map_free_vars=True)
assert not tvm.ir.structural_equal(zx * zx, zy * zy, map_free_vars=False)
- assert not tvm.ir.structural_equal(zx * zx, (vx + vx) * (vx + vx),
- map_free_vars=False)
+ assert tvm.ir.structural_equal(zx * zx, (vx + vx) * (vx + vx),
Review comment:
I'm also confused by this one, I don't see the argument for why these are
ever equal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
