anijain2305 commented on a change in pull request #5153: Adding support for QNN
subtract op
URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399454748
##########
File path: src/relay/qnn/op/op_common.h
##########
@@ -74,16 +212,17 @@ static inline bool QnnBroadcastRel(const Array<Type>&
types, int num_inputs, con
output_scale, output_zero_point}, Attrs(), {}); \
}); \
RELAY_REGISTER_OP("qnn." OpName) \
- .set_num_inputs(8) \
- .add_argument("lhs", "Tensor", "The left hand side quantized tensor.")
\
- .add_argument("rhs", "Tensor", "The right hand side quantized tensor.")
\
- .add_argument("lhs_scale", "Tensor", "The scale of the lhs tensor.")
\
- .add_argument("lhs_zero_point", "Tensor", "The zero_point of the lhs
tensor.") \
- .add_argument("rhs_scale", "Tensor", "The scale of the rhs tensor.")
\
- .add_argument("rhs_zero_point", "Tensor", "The zero_point of the rhs
tensor.") \
- .add_argument("output_scale", "Tensor", "The scale of the output tensor.")
\
- .add_argument("output_zero_point", "Tensor", "The zero_point of the output
tensor.") \
- .add_type_rel("QnnBroadcast", QnnBroadcastRel)
+ .set_num_inputs(kNumQnnBinaryOpInputs)
\
Review comment:
One last, the \ is unaligned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
