masahi commented on a change in pull request #5157: [Relay][Frontend][Pytorch] 
Fixed ConvTranspose2D parsing
URL: https://github.com/apache/incubator-tvm/pull/5157#discussion_r399529519
 
 

 ##########
 File path: tests/python/frontend/pytorch/test_forward.py
 ##########
 @@ -448,6 +448,33 @@ def forward(self, *args):
                  input_data=torch.randn((1, 8, 16, 16)))
 
 
+def test_forward_conv_transpose():
+    torch.set_grad_enabled(False)
+    input_shape = [1, 3, 10, 10]
+
+    class ConvTranspose2D1(Module):
 
 Review comment:
   New tests shouldn't introduce these wrapper modules. You ca use 
`torch.nn.ConvTranspose2d` directly. No need to have softmax. See
   
   
https://github.com/apache/incubator-tvm/blob/3aabbd9c30d247a31eb19ebf997d6074b14b5dd9/tests/python/frontend/pytorch/test_forward.py#L740-L742

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to