multiverstack-intellif commented on PR #15638: URL: https://github.com/apache/tvm/pull/15638#issuecomment-1698588609
> > Thanks for the bugfixes! Definitely not an expert here, and do you think we need to add a test for changes introduced in presurger_set.cc? > > @junrushao , > > Me either, not expert on this topic, unsure how #14690 passed it's own test (can't see related CI logs). Since here we have compilation fixes (no changes), the #14690 test case included should be sufficient. > > Let's wait the tests to pass in green, reported issue here might be related to: **(a)** a different `mlir = 16` version on my side **(b)** a newer `gcc 13` not willing to infer casts (unplausible) > > If **(a)** will adjust this PR with some little `#if version` to keep pace with MLIR API changes (mlir >= 15, as expected). > > Let's also ask authors: @multiverstack-intellif , @wrongtest-intellif I believe it's because of a), USE_MLIR is not turned ON in CI test, AFAIK, and only LLVM 14 & 15 is tested locally when #14690 is submitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
