tqchen commented on code in PR #15674:
URL: https://github.com/apache/tvm/pull/15674#discussion_r1316512081
##########
include/tvm/runtime/disco/session.h:
##########
@@ -195,6 +195,18 @@ class SessionObj : public Object {
* \param host_array The array to be copied to worker-0
* \param remote_array The NDArray on worker-0
*/
+
+ DRef CopyToWorker0Wrapper(const NDArray& host_array) {
Review Comment:
To minimize the interface, let us consider only expose remote.Empty.
Then move the wrapper to the upper level applications
##########
src/runtime/relax_vm/executable.cc:
##########
@@ -75,6 +75,10 @@ PackedFunc Executable::GetFunction(const String& name, const
ObjectPtr<Object>&
vm->LoadExecutable(GetObjectPtr<Executable>(this));
*rv = Module(vm);
});
+ } else if (name == "func_exists") {
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
