Lunderberg opened a new pull request, #15698:
URL: https://github.com/apache/tvm/pull/15698

   Prior to this commit, the `VarVisitor` used in the implementation of 
`all_vars` and `free_vars` only collected variable usage sites where the 
variable was a `const VarNode*`, and ignored usage sites of a `const 
DataflowVarNode*`.  When analyzing an entire function, these variables were 
found in the `const VisitVarBinding*`, and could pass the existing tests.  
However, when analyzing a single expression, these variables would be 
erroneously excluded.
   
   This commit adds a `VisitExpr_(const DataflowVarNode*)` implementation in 
`VarVisitor`, to collect variable usage regardless of the type of variable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to