ibsidorenko commented on PR #15686: URL: https://github.com/apache/tvm/pull/15686#issuecomment-1714188550
> I'm taking a look at [mlc-ai/mlc-llm#855](https://github.com/mlc-ai/mlc-llm/pull/855) and it makes me wonder if we need those two ops at all. The `identity` mode in smooth seems odd and unnecessary, and `R.absmax` is legalized immediately before stat collection. Thank you for review! I saw your comments there. Rather interesting idea and looks like it is possible to avoid from using these ops. I have added there in comments about motivation of adding `R.absmax` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
