Lunderberg commented on issue #15233: URL: https://github.com/apache/tvm/issues/15233#issuecomment-1736066884
I'm somewhat concerned about the `relay -> python codegen -> relax` code path used in `tvm.contrib.msc.framework.torch.frontend.translate.from_torch` when `via_relax=False`. This is a duplication of the serialization/parsing used in TVMScript (`tvm.script`), and can cause CI failures (e.g https://github.com/apache/tvm/pull/15783) due to this duplication. While I agree with the need for a operator-level conversion from relay to relax, I think it should be done through extending the existing `relax.testing.relay_translator.from_relay` converter rather than having an additional python code-generator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
