This is an automated email from the ASF dual-hosted git repository.
lunderberg pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 73e7909a71 [TVMScript] Preserve traceback across TVMScript parsing
(#15824)
73e7909a71 is described below
commit 73e7909a71f03dbdc0c8e8ad250a77597c994508
Author: Eric Lunderberg <[email protected]>
AuthorDate: Wed Sep 27 14:57:01 2023 -0500
[TVMScript] Preserve traceback across TVMScript parsing (#15824)
Prior to this commit, exceptions raised during the parsing of
TVMScript would be caught and replaced with a new exception. While
this does allow the TVMScript location of the error to be included in
the exception, it also removes the stack trace of the original error.
This commit updates the `Parser.report_error` function to provide the
original stack trace alongside the updated exception object.
---
python/tvm/script/parser/core/parser.py | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/python/tvm/script/parser/core/parser.py
b/python/tvm/script/parser/core/parser.py
index 7b7dd066c3..ae79eef126 100644
--- a/python/tvm/script/parser/core/parser.py
+++ b/python/tvm/script/parser/core/parser.py
@@ -522,7 +522,18 @@ class Parser(doc.NodeVisitor):
msg = "KeyError: " + str(err)
else:
msg = str(err)
- self.diag.error(node, msg)
+
+ try:
+ self.diag.error(node, msg)
+ except Exception as diag_err:
+ # Calling self.diag.error is guaranteed to throw an
+ # exception. When shown to a user, this error should
+ # reference the point of error within the provided
+ # TVMScript. However, when caught in pdb, the full
+ # traceback should be available for debugging.
+ if isinstance(err, Exception):
+ diag_err = diag_err.with_traceback(err.__traceback__)
+ raise diag_err
def visit(self, node: doc.AST) -> None:
"""The general visiting method.
