yongwww commented on code in PR #15833:
URL: https://github.com/apache/tvm/pull/15833#discussion_r1339353205
##########
include/tvm/runtime/memory_manager.h:
##########
@@ -63,9 +62,11 @@ class Allocator {
* \param shape The shape of the NDArray.
* \param dtype The datatype of the NDArray.
* \param dev The device where the array is allocated.
+ * \param mem_scope is the device memory scope hint.
Review Comment:
nit: \param mem_scope The device memory scope hint.
##########
include/tvm/runtime/memory_manager.h:
##########
@@ -130,7 +131,7 @@ class MemoryManager {
class StorageObj : public Object {
public:
/*! \brief The index into the VM function table. */
- Buffer buffer;
+ MBuffer buffer;
/*! \brief Allocate an NDArray from a given piece of storage. */
NDArray AllocNDArray(size_t offset, std::vector<int64_t> shape, DLDataType
dtype);
Review Comment:
It would be good to update vector<int_64_t> shape to `ShapeTuple`. I can
work on this once this pr lands
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
