ekalda commented on code in PR #15780:
URL: https://github.com/apache/tvm/pull/15780#discussion_r1345554154


##########
tests/python/contrib/test_ethosu/test_codegen.py:
##########
@@ -1564,6 +1564,30 @@ def fully_connected(x):
     )
 
 
[email protected]("accel_type", ["ethos-u55-256", "ethos-u65-256"])
[email protected]("ifm_shape", [(1, 16)])

Review Comment:
   Does it work if the first dimension of IFM is not 1? If yes, we should test 
it, if not, we should make it explicit in the `is_valid` checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to