cbalint13 commented on PR #15940: URL: https://github.com/apache/tvm/pull/15940#issuecomment-1767325750
> Hey @cbalint13 thanks a lot for the swift fix!! Yeah this issue was reported by clang++ on macOS, and I can confirm itโs gone with this change. Thanks again ๐ With pleasure, anytime. --- Just some extra info: I also checked using gcc's *"hardening"* stack-protector flags, being a default thing for fedora/redhat releng, and it is fine. Short, the very flag: ```-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong``` The full flags, added by rhel/fedora [at packaging creation time](https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md): ``` $ rpm --eval %{optflags} -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
