Lunderberg commented on issue #15233: URL: https://github.com/apache/tvm/issues/15233#issuecomment-1768532123
@Archermmt No worries, and I've been slow responding as well. After thinking on it, I think my primary concern is in the method used for the `MSCGraph -> relax` conversion, which is done by first producing a python string, then calling `exec` on the generated string. This makes it very difficult to tell where an error has been introduced, as any errors in this process are thrown at runtime while executing the generated string. Instead of generating a string to use the Python API, I think the MSC to Relax conversion should instead be done by directly calling the C++ APIs. This would expose any errors during the C++ compilation, rather than delaying them until runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
