Lunderberg commented on PR #15953: URL: https://github.com/apache/tvm/pull/15953#issuecomment-1776005746
It looks like this changes the underlying IR on the C++ side, which is a wider change than I expected given the name of the PR. Using `StringImm` for the LLVM intrinsic requires updated the LLVM codegen, and breaks IDE support for "find all references" when applied to the intrinsic's enum value. I like the user-friendliness of this change, and thing it should be implemented on the TVMScript side instead. When printing out a `tir::Call` node ([here](https://github.com/apache/tvm/blob/main/src/script/printer/tir/expr.cc#L234) in the TVMScript printer), we could check whether we are calling an LLVM intrinsic, and convert the intrinsic's integer value to string at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
