[tvm] branch unity updated: [Unity][Testing] Show failing module in WellFormedInstrument (#15898)

[wuwei]

This is an automated email from the ASF dual-hosted git repository.

wuwei pushed a commit to branch unity
in repository https://gitbox.apache.org/repos/asf/tvm.git


The following commit(s) were added to refs/heads/unity by this push:
     new 8f97a763a0 [Unity][Testing] Show failing module in 
WellFormedInstrument (#15898)
8f97a763a0 is described below

commit 8f97a763a07272a261155a54c6ec73620a87f669
Author: Eric Lunderberg <lunderb...@users.noreply.github.com>
AuthorDate: Thu Oct 26 12:26:13 2023 -0500

    [Unity][Testing] Show failing module in WellFormedInstrument (#15898)
    
    Prior to this commit, the `WellFormedInstrument` showed any error
    messages produced by the call to `relax.analysis.well_formed`, but did
    not show the ill-formed module itself.  Since this instrumentation is
    enabled for all unit tests in the `tests/python/relax` directory, CI
    logs do not include the failing module, making the logs less useful
    for debugging.
    
    This commit updates the `WellFormedInstrument` to display the
    ill-formed module prior to raising an exception.
---
 python/tvm/relax/ir/instrument.py | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/python/tvm/relax/ir/instrument.py 
b/python/tvm/relax/ir/instrument.py
index fc51a796a7..a297e3f15a 100644
--- a/python/tvm/relax/ir/instrument.py
+++ b/python/tvm/relax/ir/instrument.py
@@ -25,13 +25,19 @@ class WellFormedInstrument:
     is well formed. It will skip specific passes, like Normalize.
     """
 
-    def __init__(self):
+    def __init__(self, check_struct_info=True):
         self.skip_pass_name = ["Normalize", "ResolveGlobals"]
+        self.check_struct_info = check_struct_info
 
     def run_before_pass(self, mod, pass_info):
-        if pass_info.name not in self.skip_pass_name:
-            assert relax.analysis.well_formed(mod)
+        self._check(mod, pass_info.name, "Before")
 
     def run_after_pass(self, mod, pass_info):
-        if pass_info.name not in self.skip_pass_name:
-            assert relax.analysis.well_formed(mod)
+        self._check(mod, pass_info.name, "After")
+
+    def _check(self, mod, pass_name, name_prefix):
+        if pass_name not in self.skip_pass_name:
+            is_well_formed = relax.analysis.well_formed(mod, 
self.check_struct_info)
+            if not is_well_formed:
+                mod.show(name=f"{name_prefix}{pass_name}")
+            assert is_well_formed