Lunderberg commented on PR #15916: URL: https://github.com/apache/tvm/pull/15916#issuecomment-1783586454
> My concerns were addressed, but we should have agreement on the design question @tqchen posed before we merge (if we will merge). Oh, absolutely. The comment was to ensure that we had a clean implementation for the design comparison. > I'm not sure what form this should take, but such special cases make it trickier to implement passes like common subexpression elimination: the passes have to know about which operators are special and have special handling for them Thank you for this phrasing, as I was trying to put this sentiment into words. The existence of special requirements that must be preserved makes generic implementations of other passes be much more difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
