tqchen commented on code in PR #15992:
URL: https://github.com/apache/tvm/pull/15992#discussion_r1375526941
##########
include/tvm/relax/expr.h:
##########
@@ -796,9 +798,6 @@ class MatchCast : public Binding {
class VarBindingNode : public BindingNode {
public:
- /*! \brief The binding value. */
- Expr value;
Review Comment:
We intentionally keep the value in the subclass, because in match clas there
is extra set of struct info to be considered(that can populates new values),
and it is important to keep reminding the users of this.
The extra dispatch is worth overall for this explicitness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
