tqchen commented on PR #15835: URL: https://github.com/apache/tvm/pull/15835#issuecomment-1789314560
My read is that for kernel generators(where we know there won't be cross function call, or we know we do not yet support kernel function call), we can safely remove https://github.com/Lunderberg/tvm/blob/e8ef2f25f45f44aabfa1652027a05b3aae4c67f8/src/target/source/codegen_metal.cc#L352C2-L354C6 and add a comment that we skip declaration as the cross-kernel calls are not supported -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
