Ubospica commented on code in PR #16039:
URL: https://github.com/apache/tvm/pull/16039#discussion_r1384217324
##########
include/tvm/target/tag.h:
##########
@@ -131,6 +137,11 @@ inline TargetTagRegEntry&
TargetTagRegEntry::set_config(Map<String, ObjectRef> c
return *this;
}
+inline TargetTagRegEntry& TargetTagRegEntry::add_config(String key, ObjectRef
value) {
+ tag_->config.Set(key, value);
Review Comment:
I think it is ok given the name is with_config. `Set` will work whether the
key is already set.
##########
include/tvm/target/tag.h:
##########
@@ -131,6 +137,11 @@ inline TargetTagRegEntry&
TargetTagRegEntry::set_config(Map<String, ObjectRef> c
return *this;
}
+inline TargetTagRegEntry& TargetTagRegEntry::add_config(String key, ObjectRef
value) {
+ tag_->config.Set(key, value);
Review Comment:
I think it should be ok given the name is with_config. `Set` will work
whether the key is already set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
