Lunderberg commented on code in PR #16068:
URL: https://github.com/apache/tvm/pull/16068#discussion_r1385041435
##########
include/tvm/relax/block_builder.h:
##########
@@ -231,6 +232,48 @@ class BlockBuilder : public ObjectRef {
*/
TVM_DLL static BlockBuilder Create(Optional<IRModule> ctx_mod);
+ /*! \brief A marker struct to disable FNormalize
+ *
+ * This struct is used as a marker to disable the use of FNormalize
+ * by this block builder. This should only be used for TVMScript
+ * parsing, which may require producing un-normalized Relax IR for
+ * testing purposes, and to ensure that round-trips are unchanged.
+ *
+ * The name is deliberately verbose to draw attention during a code
+ * review. The explicit default constructor prevents aggregate
Review Comment:
Thank you. Since any unnormalized operator is now considered ill-formed, I
wanted to make it as obvious as possible when the per-operator normalization is
being disabled. It was rather amusing how many lint checks needed to be
disabled in order to ensure that the parameter name occurs at every call site.
(Lint rules generally aren't aimed at making intentionally-verbose code.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
