Lunderberg commented on code in PR #16088:
URL: https://github.com/apache/tvm/pull/16088#discussion_r1388076125
##########
python/tvm/relax/transform/lazy_transform_params.py:
##########
@@ -118,9 +119,15 @@ class LazyTransformParamsMutator(PyExprMutator):
The module to be transformed
"""
- def __init__(self, mod: IRModule = None) -> None:
+ def __init__(
+ self, fget_item, fset_item, get_item_param, set_item_param, mod:
IRModule = None
Review Comment:
Hmm, looks like the analysis would need to be split apart as well. In
general, I think having multiple smaller changes is better than a single
mutator, but this seems like a refactor than would make sense to ask in a
feature addition PR. The current revision looks good, and any additional
changes can be in a follow-up PR if desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
