slyubomirsky commented on code in PR #15689: URL: https://github.com/apache/tvm/pull/15689#discussion_r1393369005
########## include/tvm/relax/utils.h: ########## @@ -110,6 +110,11 @@ TVM_DLL Function CopyWithNewVars(Function func); */ Expr ToNonDataflow(const Expr& e); +/*! + * \brief Get the value bound in the binding. + */ +Expr GetBoundValue(const Binding& b); Review Comment: It's since been merged in another change, so I guess it's moot for now. FWIW I think hoisting the value field is the right choice, but I tried it and it breaks _a lot_ of uses. Probably still worth doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
