vvchernov commented on code in PR #16131:
URL: https://github.com/apache/tvm/pull/16131#discussion_r1395238258
##########
python/tvm/relay/frontend/pytorch.py:
##########
@@ -1546,6 +1546,16 @@ def flatten(self, inputs, input_types):
out = _op.squeeze(out, axis=squeeze_axes)
return out
+ def unflatten(self, inputs, input_types):
+ data = inputs[0]
+ dim = int(inputs[1])
+ unflattened_size = tuple(inputs[2])
+ dshape = get_const_tuple(self.infer_shape_with_prelude(data))
+ assert len(dshape) > dim
+ new_shape = dshape[:dim] + unflattened_size + dshape[dim + 1 :]
Review Comment:
Hello @mshr-h! Ok torch.jit.trace do it, but in this case we do not need
`assert len(dshape) > dim`.
It looks like TVM usually rechecks all corner cases.
About -1 in unflattened_size. In this case we can multiply together other
dimension and check dshape[dim] % mult == 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
