tqchen commented on PR #16183:
URL: https://github.com/apache/tvm/pull/16183#issuecomment-1832557090
Just highlight some of the main comments that are high level
- naming: we can probably go with `runtime::Int`, `runtime::Float`,
`runtime::Bool` as they are more understandable terms
- we should remove tvm::Integer and tvm::bool after migrating their usage
to boxed values(in later PR)
- convention: It is cleaner to have a convention where runtime::Int and
runtime::Float always get unboxed when passing into TVMArg and TVMRet.
- The codegen layer that expects int/float then do not need to deal with
object.
- That does mean the FFI layer needs to explicitly unbox when setting
boxed values into them (seems the current impl is already doing so for TVMRet,
need to check argument setting as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
