slyubomirsky commented on code in PR #16204:
URL: https://github.com/apache/tvm/pull/16204#discussion_r1416180814
##########
src/relax/transform/canonicalize_bindings.cc:
##########
@@ -118,9 +119,28 @@ class CanonicalizePlanner : public ExprVisitor {
}
private:
+ void VisitExpr_(const FunctionNode* func) override {
+ // for functions, treat any free vars as used outside their home DF block
Review Comment:
In the specification, I actually wrote that we should not allow DF vars to
be captured at all. Unless there's a compelling need to deal with that extra
complexity, I'm happy to stick with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
