Lunderberg commented on PR #16195: URL: https://github.com/apache/tvm/pull/16195#issuecomment-1856500519
Agreed on testing for error cases. I tend to add the tests when writing new checks, as I'm already in the process of writing the associated tests, and therefore have a way to drive the function. When updating/tweaking existing errors I frequently omit them, because it may not be easy/possible to write a test case using only the public APIs that exactly hits the specific error case. (Granted, difficulty in writing specific tests is an issue in itself, and refactoring to allow better tests is a net positive. But I tend to go down those rabbit holes with disturbing regularity, and try to cut myself off where possible.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
