masahi commented on a change in pull request #5186: [Relay][Topi][AutoTVM] Winograd support for Conv3D URL: https://github.com/apache/incubator-tvm/pull/5186#discussion_r403412557
########## File path: src/relay/op/nn/convolution.h ########## @@ -360,6 +363,540 @@ bool Conv3DRel(const Array<Type>& types, int num_inputs, const Attrs& attrs, return true; } + +// Winograd convolution shape relations +template<typename AttrType> Review comment: why not make them inline function instead of template? If this function is not intended to be polymorphic, making it a template can be confusing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
