tqchen commented on code in PR #16284: URL: https://github.com/apache/tvm/pull/16284#discussion_r1445269907
########## python/tvm/relax/frontend/nn/core.py: ########## @@ -67,6 +67,8 @@ _DEFAULT_DTYPE = "float32" +# If a shape is specified as a string `name`, we create a `tvm.tir.Var(name, "int64")` +ShapeVar = Union[int, str, tir.PrimExpr] Review Comment: I see, given this list do not grow, i still think being explicit would be better, since it also helps the readers to learn about what can be passed in directly through signature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
