Lunderberg commented on PR #16356: URL: https://github.com/apache/tvm/pull/16356#issuecomment-1881892694
Sounds good. The test case would be primarily for future-proofing. Since this can improve readability for many cases, I can imagine a later PR being submitted to change the default, especially if the author is unaware of the potential pitfalls (i.e. like me prior to this thread). A test case for a known case that is difficult to round-trip correctly would catch the error when that hypothetical PR is submitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
