LeiWang1999 opened a new pull request, #16406:
URL: https://github.com/apache/tvm/pull/16406

   Here if a fix of `LowerCrossThreadReduction`: The pass will remove all the 
loops with thread bind under the inter thread reduction block, which will 
introduce some issues when we meet the case where there could be other 
non-reduction blocks under the reduction thread.
   
   Before removing a thread-bound loop, check if the block(s) under this loop 
has reduction block var. If the block(s) under have reduction do not have any 
reduction block var, it means that block is not reduction, and therefore this 
thread-bound loop should be kept. Otherwise, we remove the thread-bound loop as 
usual.
   
   related discussion: 
https://discuss.tvm.apache.org/t/missing-thread-bind-loops-under-block-reduction-when-transformed-with-tir/16232/6
   
   Please CC @MasterJH5574 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to