lhutton1 commented on code in PR #16401:
URL: https://github.com/apache/tvm/pull/16401#discussion_r1453214031
##########
python/tvm/relay/op/contrib/ethosu.py:
##########
@@ -1810,27 +1811,37 @@ def __init__(self, func_body):
from tvm.relay.backend.contrib.ethosu.util import QDenseArgs # type:
ignore
from tvm.relay.backend.contrib.ethosu.util import BiasAddArgs,
RequantArgs
+ fract_scale = tvm.relay.Constant(tvm.nd.array(np.array(1 / 2**15)))
Review Comment:
Out of curiosity, where does `1/2**15` come from?
##########
src/relay/backend/contrib/ethosu/compiler_attrs.cc:
##########
@@ -72,6 +73,13 @@ struct EthosUCompilerConfigNode : public
tvm::AttrsNode<EthosUCompilerConfigNode
"the linker script for section \".rodata.tvm\" that the constants
are located in SRAM)")
.set_default(Bool(false));
String dev_warning = "Option is intended for development and debugging
purposes only. ";
+ TVM_ATTR_FIELD(enable_fixed_point)
Review Comment:
Curious why this needs to be passed as an option, could you imply fixed
point when an int16 nn.dense operator is used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
