Lunderberg commented on PR #16457: URL: https://github.com/apache/tvm/pull/16457#issuecomment-1906408165
Currently a proof-of-concept, as it would require testing 1. Verify that `relax::IfNode` supports a `relax::PrimValue` with boolean dtype. 2. Handling special-cases that check for a relax value (e.g. `R.zeros`), rather than just symbolic variables. 3. Improved StructInfo inference when calling a function within a constrained scope. (e.g. It's okay to pass `R.Tensor([N])` to a function expecting `R.Tensor([16])` if it is within a scope of `if N==16`.) 4. Improved TVMScript parsing for `relax::If`. Currently, the use of `Emit` without a previously defined struct info causes `EraseToWellDefined` to remove the known shape. 5. Improved LCA handling for the branches. For example, if the `if N==16` branch produces `R.Tensor([16])` and the `else` branch produces `R.Tensor([N])`, the LCA should be `R.Tensor([N])`. Currently, this results in `R.Tensor(ndim=1)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
