tqchen opened a new issue #5250: [REFACTOR] StringImm -> String URL: https://github.com/apache/incubator-tvm/issues/5250 We have introduced the runtime::String to the tvm runtime. This new object can be used to replace most of the StringImm usages, except for the one that uses the IR. This issue tracks the refactor items to perform such migration - [ ] Expose runtime::String to the tvm namespace https://github.com/apache/incubator-tvm/blob/master/include/tvm/node/node.h#L59 - [ ] Change ffi_node_api String to return runtime::String instead of StringImm https://github.com/apache/incubator-tvm/blob/master/python/tvm/runtime/object_generic.py#L59 - [ ] Remove the constructor from const char* for PrimExpr, this will reveal a lot of failures in compiler checks for the cases where we need to use String instead. - [ ] At this point, we will need quite a lot of failures in the topi side, fix most of the occurence of StringImm(usually under type PrimExpr and Array<PrimExpr>) - [ ] Keep the compiler ir part to still use StringImm
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
