canesche commented on PR #16499: URL: https://github.com/apache/tvm/pull/16499#issuecomment-1921189672
> I'm not main developer, but I have few suggestions to improve code quality.: > > * try to not mix 2 formatting methods f-string and %-formatting. I think we should prefer f-string, because it is more robust and actual. > * try to not one-letter variables. > * not sure if your PR is suitable for tests, but it would be great to have some unit tests for your code. Thank you @pfk-beta ! All comments are very welcome. I'll improve my code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
