quic-sanirudh commented on issue #16488:
URL: https://github.com/apache/tvm/issues/16488#issuecomment-1923345711

   These changes were done a while back to support LLVM 18 in #15921. I think 
the `#ifdef` macro guards should have ensured that we use the correct type if 
the LLVM version was >= 18.0.
   
   For example in llvm_instance.cc, [this 
condition](https://github.com/quic-sanirudh/tvm/blob/7648e14ed019f672eb380de1f14beff6a51ad568/src/target/llvm/llvm_instance.cc#L467)
 should become false and it should use the right check.
   
   I'm using LLVM 18 and I'm not seeing the build errors, so could you please 
check whether the TVM_LLVM_VERSION macro is set correctly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to