Lunderberg commented on code in PR #16560:
URL: https://github.com/apache/tvm/pull/16560#discussion_r1488345117


##########
src/tir/schedule/primitive/blockize_tensorize.cc:
##########
@@ -738,6 +739,28 @@ StmtSRef Blockize(ScheduleState self, const 
Array<StmtSRef>& blocks, bool preser
   return result;
 }
 
+class TensorIntrinSimplifier : public arith::IRMutatorWithAnalyzer {
+ public:
+  static PrimFunc Apply(PrimFunc func, arith::Analyzer* analyzer) {

Review Comment:
   Instead of simplifying the body of the `PrimFunc`, can we instead simplify 
the entire `PrimFunc`?  That way, dynamic expressions that are used in shapes 
are exposed to the analyzer as non-negative.  (e.g. Using buffer of shape 
`[n,m]` implies that `n >= 0 && m >= 0`.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to