Lunderberg commented on PR #16563: URL: https://github.com/apache/tvm/pull/16563#issuecomment-1947309703
> The implementation seems solid, a very good change. I like the parameterized test cases too. The use of the _DLTensorShapeProxy resulted in an elegant UI in tvmscript. Thank you! I really like polishing up the interface to be as clean as possible. (For my own sake if nothing else, as I am liable to forget a builtin-function name, but am much less likely to forget `obj.dtype`.) > Idle musing: I wonder if there's any way the PrimFuncs can be unrolled in cases where the parameters are known at compile time. Prior to `LegalizeOps`, this is implicitly done by the `FNormalize` implementation for each operator. After `LegalizeOps`, not so much. While the `FoldConstant` pass can compile/run TIR functions if their arguments are known, there isn't a good way to indicate that a TIR function only requires the DLTensor struct, and not the data itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
