slyubomirsky commented on code in PR #16569:
URL: https://github.com/apache/tvm/pull/16569#discussion_r1491682704
##########
tests/python/tir-base/test_tir_specialize.py:
##########
@@ -65,7 +65,7 @@ def matmul_m_128(a: T.handle, b: T.handle, c: T.handle) ->
None:
C[vi, vj] = C[vi, vj] + A[vi, vk] * B[vj, vk]
[email protected]_func
[email protected]_func(check_well_formed=False)
Review Comment:
Not clear to me what's wrong here
##########
tests/python/tir-base/test_tir_specialize.py:
##########
@@ -275,7 +275,8 @@ def before(A: T.Buffer([16, 16], "float32"), B:
T.Buffer([16, 16], "float32")):
for i in range(256):
B_flat[i] = A_flat[i] * 2.0
- @T.prim_func(private=True)
+ # well-formed checker complains about multiple nested definitions of
B_flat?
Review Comment:
This error was especially baffling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
